Skip to content

Conversation

@jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented Jan 5, 2026

The previous definition here was causing Typescript errors when passing SDK-supported method options (e.g. headers)

Screenshot 2026-01-05 at 1 12 46 PM

Since these methods do not use the satisfies ServiceMethodDynamicSegments (and return their own Generic) the type needs to be explicitly defined.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.25%. Comparing base (5852572) to head (bdfe750).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files          84       84           
  Lines        1561     1561           
  Branches      248      248           
=======================================
  Hits         1487     1487           
  Misses         73       73           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbottigliero jbottigliero merged commit 1df9ba5 into main Jan 7, 2026
10 checks passed
@jbottigliero jbottigliero deleted the fix-Search-argument-signatures branch January 7, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants