fix(Typescript): use BaseServiceMethodOptions in ServiceMethodDynamicSegments #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change made in 72a3c49 is now missing the other properties. I checked the following in the ts playground, so I think this will leave the required fields required and the optional fields optional. ```ts type A = { a?: unknown; b?: unknown; } type B = { b: unknown; } const b = { b: 'b'; // commenting this out should cause a type error } ```
jbottigliero
changed the title
jbottigliero
approved these changes
Dec 16, 2025
jbottigliero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change made in 72a3c49 is now missing the other properties. I checked the following in the ts playground, so I think this will leave the required fields required and the optional fields optional.