Proposal: add support to expose functions on a public domain#22
Open
Proposal: add support to expose functions on a public domain#22
Conversation
wpjunior
requested review from
MayconDionisio,
andreribeirocoelho and
mateuspontes
heitorsilva
suggested changes
Mar 16, 2018
Contributor
heitorsilva
left a comment
heitorsilva
left a comment
There was a problem hiding this comment.
I also miss some linting on the entire Functions code...
| data.exposed = 'true'; | ||
| } else if (code.exposed === false) { | ||
| data.exposed = 'false'; | ||
| } |
Contributor
There was a problem hiding this comment.
All of this could be:
data.exposed = code.exposed.toString();https://developer.mozilla.org/pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Boolean/toString
mateuspontes
reviewed
May 3, 2018
Contributor
There was a problem hiding this comment.
This is a nice-to-have feature. Please, fix conflicts, lint your files and follow recommendations from @heitorsilva
markiing
force-pushed
the
master
branch
3 times, most recently
from
8dee678 to
eab0f61
Compare
ceelsoin
force-pushed
the
master
branch
4 times, most recently
from
c3c3f61 to
9297c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each function could have a new boolean attribute named
exposed, besides that, the server could accept connection on a public domain specified by the environment variable.All exposed function may be accessible on
http://${EXPOSABLE_HOST}/${namespace}/${functionID}, avoiding to expose the private API on the same domain.