Skip to content

fix(docker): add git fetch --tags for versioned builds #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breezytm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(docker): add git fetch --tags for versioned builds #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee0b63e
fix: ensure git tag is fetched before checkout
breezytm Oct 22, 2025
753b4ff
fix: ensure git tag is fetched before checkout
breezytm Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geth/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ WORKDIR /op-geth

ARG OPGETH_VERSION

RUN git checkout $OPGETH_VERSION
RUN git fetch --tags && git checkout "tags/${OPGETH_VERSION}"
Copy link
Collaborator

@ihooni ihooni Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about clone with single branch?

> git clone https://github.com/ethereum-optimism/op-geth.git --branch v1.101603.1 --single-branch

Copy link
Author

@breezytm breezytm Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should work

RUN git clone --branch ${OPGETH_VERSION} --single-branch https://github.com/ethereum-optimism/op-geth.git


RUN make geth
# -------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion node/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ WORKDIR /optimism

ARG OPNODE_VERSION

RUN git checkout op-node/$OPNODE_VERSION
RUN git fetch --tags && git checkout op-node/$OPNODE_VERSION

COPY --from=just-builder /app/just /usr/local/bin/

Expand Down