feat: add registry base class and opaque handle concepts#15
Open
gituser12981u2 wants to merge 4 commits into
Open
feat: add registry base class and opaque handle concepts#15gituser12981u2 wants to merge 4 commits into
gituser12981u2 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the RFC-0001 and RFC-0002 (#11 and #14).
This is implemented in the registry_base.hpp, registry_concepts.hpp, and opaque_handle.hpp all under include/engine.
I still need to properly comment these with DOxygen.
I also update frame registry to use the registry base class and deleted device and instance registry/handles since they are not needed for such low level objects, probably.