chore: headless mode#12
Merged
Merged
Conversation
Owner
|
@alexcu2718 Can you code review the changes? I added the QUARK_HEADLESS flag in the cmake files. I gated the cmake in presenter on the flag and then a bunch of methods in vulkan_context on the flag as well. I also edited the vcpkg file so it doesn't manifest glfw on headless builds which makes linux builds pass without needing xorg or any GUI stuff, which is nice. I removed the stuff that you put in ci.yml for the headless build. I didn't really understand it since the action runners are headless by default anyways, so we should only need to remove code from ci.yml and not add more lines. Feel free to add it back if there is a misunderstanding and the things you added were needed. |
gituser12981u2
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge testing CI