Fix delete-preview action container requirements #21186
Draft
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix leeway command not found error in preview garbage collection workflow by adding container specification to the delete job. The composite delete-preview action requires leeway to be available, which is only present in the dev-environment container. This matches the fix applied to preview-env-delete.yml. Co-authored-by: Ona <no-reply@ona.com>
Fix leeway command not found error in all workflows that use the delete-preview composite action by adding container specifications to their delete jobs. The composite delete-preview action requires leeway to be available, which is only present in the dev-environment container. Affected workflows: - ide-integration-tests.yml - workspace-integration-tests.yml - preview-env-check-regressions.yml Co-authored-by: Ona <no-reply@ona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After converting the
delete-previewaction from a Docker container action to a composite action, workflows that call this action onubuntu-latestrunners fail with "leeway: command not found" errors.This PR adds container specifications to all delete jobs that use the
delete-previewaction, ensuring they run in the dev-environment container where leeway is available.Related Issue(s)
Fixes the preview garbage collection workflow failures and prevents similar failures in integration test workflows.
How to test
Changes
preview-env-gc.ymlide-integration-tests.ymlworkspace-integration-tests.ymlpreview-env-check-regressions.ymlEach delete job now runs in
eu.gcr.io/gitpod-core-dev/dev/dev-environment:main-gha.34181with--user rootoption.