chore(deps): update electron to v42 and migrate to async safeStorage#2839
Open
afonsojramos wants to merge 2 commits intomainfrom
Open
chore(deps): update electron to v42 and migrate to async safeStorage#2839afonsojramos wants to merge 2 commits intomainfrom
afonsojramos wants to merge 2 commits intomainfrom
Conversation
|
Member
Author
|
@BlueManCZ can you test this branch to validate that it indeed works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
electronfrom 41.5.0 to 42.0.0.src/main/handlers/storage.tsto the new asyncsafeStorage.encryptStringAsync/decryptStringAsyncintroduced in electron/electron#49054, which usesos_crypt_asyncto discover Linux secret service providers via D-Bus instead of relying onXDG_CURRENT_DESKTOP.Test plan