test(runtimes): add validate() branch coverage in runtime extensions by Copilot · Pull Request #518 · githubnext/ado-aw

Copilot · 2026-05-12T12:27:21Z

Summary

validate() branch coverage was missing for runtime extensions despite integration coverage being present, leaving user-facing error/warning paths unprotected (especially dotnet global.json conflict handling).
This PR adds focused runtime-local unit tests to close those gaps for Python, Node, Dotnet, and Lean.

Python runtime (src/runtimes/python/extension.rs)
- Adds tests for all key validate() branches:
  - bash-disabled warning
  - config + feed-url mutual exclusion error
  - config-only warning
  - invalid feed URL rejection
  - version injection rejection
Node runtime (src/runtimes/node/extension.rs)
- Mirrors Python branch coverage for the same 5-path validate() structure.
Dotnet runtime (src/runtimes/dotnet/extension.rs)
- Adds tests for all major validate() branches, including filesystem-dependent behavior:
  - bash-disabled warning
  - config + feed-url mutual exclusion error
  - invalid feed URL rejection
  - version injection rejection
  - GLOBAL_JSON_SENTINEL bypass behavior
  - global.json conflict error when explicit version is set
  - sentinel accepted when global.json exists
  - config injection rejection
Lean runtime (src/runtimes/lean/extension.rs)
- Adds test for bash-disabled warning branch.

#[test]
fn test_validate_global_json_conflict_bails() {
    let tmp = tempfile::tempdir().unwrap();
    std::fs::write(tmp.path().join("global.json"), r#"{"sdk":{"version":"8.0.100"}}"#).unwrap();

    let (fm, _) = parse_markdown(
        "---\nname: test\ndescription: test\nruntimes:\n  dotnet:\n    version: '9.0.x'\n---\n",
    )
    .unwrap();
    let dotnet = fm.runtimes.as_ref().unwrap().dotnet.as_ref().unwrap();
    let ext = DotnetExtension::new(dotnet.clone());
    let ctx = CompileContext::for_test_with_compile_dir(&fm, tmp.path());

    let err = ext.validate(&ctx).unwrap_err();
    assert!(err.to_string().contains("global.json"));
}

Test plan

Unit-test coverage was added directly in each runtime extension module under #[cfg(test)].
New tests target validate() warning/error branches and dotnet’s compile-dir global.json conflict/sentinel paths.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

spsprodeus21.vssps.visualstudio.com
- Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.397kr33b076uzi2xz4x5q7l6j.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.3g161rdlnjehcpwpw89b0e4hh.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.3l7dluq3jl4z2twkxwf9mvx2m.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.3lplfaqdlklqw91syat1plde8.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.41odaej9mh5sn77m2rjar50im.1anmsf2.rcgu.o b.0r646wzmnsrf1n7bytgpjb88a.1bx9plx.rcgu.o b.16orrtqskzez1g32onkzo83vi.1bx9plx.rcgu.o b.1778bbhi7e5hkxaw5nl1jqruj.1bx9plx.rcgu.o b.1d0ck9rxo25a7fxofg624u1by.1bx9plx.rcgu.o b.1f2g58qoyjih3du0x8xvtchxj.1bx9plx.rcgu.o b.1fqoi34wyqfk8dycd0vt29s1l.1bx9plx.rcgu.o b.1gcl7iytxntv7nljmqu8h11yy.1bx9plx.rcgu.o b.1hvsrjg564se9k6i84zx4n18m.1bx9plx.rcgu.o b.1i2kcjxs7gl6ur6hcoftevybq.1bx9plx.rcgu.o b.1qpf12qtkcfjtw9v1g6hgjcfy.1bx9plx.rcgu.o b.29rij194caixrejrzzqv6vmwq.1bx9plx.rcgu.o b.29uzncd9tg5t8napfpq6fkqbj.1bx9plx.rcgu.o b.2ebd6nvh5wzvfmehs50rq2co0.1bx9plx.rcgu.o b.2elgnmxzag0hdgy2uim9a8e7p.1bx9plx.rcgu.o (dns block)
- Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 --crate-type bin --emit=dep-info,metadata -C embed-bitcode=no r01x2wfhr8u6zfbco5x.1mrnmaw.rcgu.o baolq8s6dtp36pv118k.1mrnmaw.rcgu.o 3xt3oko0307bv66tf7a.1mrnmaw.rcgu.o wapcm2t4on72phdpq7t.1mrnmaw.rcgu.o 6x65nnhs7e3xbeubhid.1mrnmaw.rcgu.o o0qw3tdc692gmd810vl.1mrnmaw.rcgu.o 7ywqx6da6h6q5fcwyko.1mrnmaw.rcgu.o v54s6r7lwu4wtglvnxv.1mrnmaw.rcgu.o 85utdyjlmwoda29gqkl.1mrnmaw.rcgu.o vmp24pk9lw48jwzoyza.1mrnmaw.rcgu.o xh2rndctintoeseurhp.1mrnmaw.rcgu.o vp74eeff6oo6lc8naoc.1mrnmaw.rcgu.o l7sc6ux8ue2xzhg9ofv.1mrnmaw.rcgu.o 5vgauemxcmd2ymzjvfw.1mrnmaw.rcgu.o (dns block)
spsprodweu4.vssps.visualstudio.com
- Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.397kr33b076uzi2xz4x5q7l6j.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.3g161rdlnjehcpwpw89b0e4hh.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.3l7dluq3jl4z2twkxwf9mvx2m.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.3lplfaqdlklqw91syat1plde8.1anmsf2.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/mcp_http_tests-a585c248149668b/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/cli_tests-beb8db084d5b4f75.41odaej9mh5sn77m2rjar50im.1anmsf2.rcgu.o b.0r646wzmnsrf1n7bytgpjb88a.1bx9plx.rcgu.o b.16orrtqskzez1g32onkzo83vi.1bx9plx.rcgu.o b.1778bbhi7e5hkxaw5nl1jqruj.1bx9plx.rcgu.o b.1d0ck9rxo25a7fxofg624u1by.1bx9plx.rcgu.o b.1f2g58qoyjih3du0x8xvtchxj.1bx9plx.rcgu.o b.1fqoi34wyqfk8dycd0vt29s1l.1bx9plx.rcgu.o b.1gcl7iytxntv7nljmqu8h11yy.1bx9plx.rcgu.o b.1hvsrjg564se9k6i84zx4n18m.1bx9plx.rcgu.o b.1i2kcjxs7gl6ur6hcoftevybq.1bx9plx.rcgu.o b.1qpf12qtkcfjtw9v1g6hgjcfy.1bx9plx.rcgu.o b.29rij194caixrejrzzqv6vmwq.1bx9plx.rcgu.o b.29uzncd9tg5t8napfpq6fkqbj.1bx9plx.rcgu.o b.2ebd6nvh5wzvfmehs50rq2co0.1bx9plx.rcgu.o b.2elgnmxzag0hdgy2uim9a8e7p.1bx9plx.rcgu.o (dns block)
- Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 --crate-type bin --emit=dep-info,metadata -C embed-bitcode=no r01x2wfhr8u6zfbco5x.1mrnmaw.rcgu.o baolq8s6dtp36pv118k.1mrnmaw.rcgu.o 3xt3oko0307bv66tf7a.1mrnmaw.rcgu.o wapcm2t4on72phdpq7t.1mrnmaw.rcgu.o 6x65nnhs7e3xbeubhid.1mrnmaw.rcgu.o o0qw3tdc692gmd810vl.1mrnmaw.rcgu.o 7ywqx6da6h6q5fcwyko.1mrnmaw.rcgu.o v54s6r7lwu4wtglvnxv.1mrnmaw.rcgu.o 85utdyjlmwoda29gqkl.1mrnmaw.rcgu.o vmp24pk9lw48jwzoyza.1mrnmaw.rcgu.o xh2rndctintoeseurhp.1mrnmaw.rcgu.o vp74eeff6oo6lc8naoc.1mrnmaw.rcgu.o l7sc6ux8ue2xzhg9ofv.1mrnmaw.rcgu.o 5vgauemxcmd2ymzjvfw.1mrnmaw.rcgu.o (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/9568a265-a2fd-4403-90d2-456246734c24 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>

Initial plan

a723b40

Copilot AI assigned Copilot and jamesadevine May 12, 2026

Copilot started work on behalf of jamesadevine May 12, 2026 12:27 View session

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request

🧪 Test gap analysis — 4 gaps found in runtime extension validate() unit tests #517

Open

test(runtimes): add validate() branch tests in runtime extensions

857507e

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/9568a265-a2fd-4403-90d2-456246734c24 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add unit tests for validate() in runtime extensions~~ test(runtimes): add validate() branch coverage in runtime extensions May 12, 2026

Copilot AI requested a review from jamesadevine May 12, 2026 12:38

Copilot finished work on behalf of jamesadevine May 12, 2026 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(runtimes): add validate() branch coverage in runtime extensions#518

test(runtimes): add validate() branch coverage in runtime extensions#518
Copilot wants to merge 2 commits into
mainfrom
copilot/add-unit-tests-runtime-extensions

Copilot AI commented May 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 12, 2026 •

edited

Loading