fix: clean up command templates (specify, analyze)#1810
Conversation
- specify.md: fix self-referential step number (step 6c → proceed to step 7)
- specify.md: remove empty "General Guidelines" heading before "Quick Guidelines"
- analyze.md: deduplicate {ARGS} — already present in "User Input" section at top
dhilipkumars
left a comment
dhilipkumars
left a comment
There was a problem hiding this comment.
some comments from myside
cc: @mnriem
There was a problem hiding this comment.
Pull request overview
Cleans up command prompt templates under templates/commands/ to remove minor inconsistencies/redundancy and improve instruction clarity for the specify and analyze commands.
Changes:
- Fixes an incorrect step reference in
specify.md(validation pass now proceeds to step 7, matching “Report completion”). - Removes an empty
## General Guidelinesheading fromspecify.md. - Removes a duplicated
{ARGS}block inanalyze.md, keeping context passed via## User Inputwhile still retaining a single{ARGS}reference.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/commands/specify.md | Corrects step cross-reference and removes an empty heading for cleaner instructions. |
| templates/commands/analyze.md | Eliminates redundant {ARGS} section and replaces it with a single inline context line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mnriem
left a comment
mnriem
left a comment
There was a problem hiding this comment.
Please address the feedback given by @dhilipkumars and Copilot. If not applicable, please explain why.
Address PR review feedback from @dhilipkumars: keep the ## Context markdown heading to preserve structural hierarchy for LLM parsing.
|
@dhilipkumars @mnriem I've addressed the feedback — restored the |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…recation Merged upstream changes: - fix: clean up command templates (specify, analyze) (github#1810) - fix: migrate Qwen Code CLI from TOML to Markdown format (github#1730) - fix(cli): deprecate explicit command support for agy (github#1808) - Add /selftest.extension core extension to test other extensions (github#1758) - feat(extensions): Quality of life improvements for RFC-aligned catalog (github#1776) Conflict resolution: - README.md: Kept our categorized agent table, added Jules agent - extensions/catalog.json: Added selftest extension, kept our extensions - src/specify_cli/__init__.py: Kept our extension management, added agy deprecation - src/specify_cli/extensions.py: Merged improvements, kept our qwen toml format - tests/test_ai_skills.py: Added upstream's qwen markdown tests
Summary
## General Guidelinesheading that has no content before## Quick Guidelines{ARGS}— the## Contextsection at the bottom repeats the same arguments already present in the## User Inputsection at the topTest plan
specify.mdstep 6c correctly references step 7specify.mdanalyze.mdstill passes{ARGS}context correctly via the## User Inputsection