Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release publishing workflow to newer GitHub Actions versions and adjusts the Node/npm publishing setup as part of an OIDC migration effort.
Changes:
- Upgraded
actions/checkoutandactions/setup-nodefrom v3 to v4 in the publish workflow. - Bumped the publish workflow Node version from 22 to 24.
- Removed npm token-based authentication from the npmjs publish step (implying an OIDC/trusted publishing flow).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Upgrades checkout/setup-node actions to v4, bumps Node version, and changes publishing auth behavior for npm/GitHub Packages. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (3)
.github/workflows/publish.yml:27
- The npm publish step no longer provides any registry credentials (NODE_AUTH_TOKEN was removed). Unless this package has npm Trusted Publishing (OIDC) configured on npmjs.com,
npm publishwill be unauthenticated and fail. If Trusted Publishing isn’t configured, re-introduce an auth token (e.g., NODE_AUTH_TOKEN from a secret) for the publish step; if it is configured, consider adding a short note/guard to make the dependency on OIDC explicit to avoid future breakage.
- run: npm version ${TAG_NAME} --git-tag-version=false
env:
TAG_NAME: ${{ github.event.release.tag_name }}
- run: npm --ignore-scripts publish --provenance --access public
.github/workflows/publish.yml:42
- In this job,
actions/setup-nodeis configuring the GitHub Packages registry (npm.pkg.github.com), but there is noNODE_AUTH_TOKEN(or other npm auth) provided anywhere in the job. Since setup-node typically writes an .npmrc that references NODE_AUTH_TOKEN, the laternpm publishis likely to fail with 401 unless auth is injected elsewhere. Consider settingNODE_AUTH_TOKENfor the job/publish step (commonly${{ github.token }}/${{ secrets.GITHUB_TOKEN }}) or otherwise explicitly configuring npm auth for this registry.
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 24
registry-url: https://npm.pkg.github.com
cache: npm
scope: '@github'
.github/workflows/publish.yml:16
- PR title suggests upgrading GitHub Actions to v4, but only
publish.ymlis updated here;.github/workflows/test.ymlstill usesactions/checkout@v3andactions/setup-node@v3. If the intent is a repo-wide Actions v4 upgrade, consider updating the other workflows as well (or adjust the PR title/scope to match).
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+15
to
20
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 | ||
| registry-url: https://registry.npmjs.org/ | ||
| cache: npm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
OIDC migration