Contributors/tom naughton/269 add additional social icons by abbycabs · Pull Request #378 · github/maintainermonth

abbycabs · 2026-03-21T01:21:59Z

Should also merge in #371

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR adds additional social links (Bluesky and Twitch) to the site footer, including new SVG icon components and corresponding i18n literals.

Changes:

Added IconBluesky and IconTwitch SVG React components under public/icons/.
Extended footer i18n literals with Bluesky/Twitch labels + URLs.
Updated components/footer/Footer.jsx to render the new social buttons.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
public/icons/bluesky.js	New Bluesky SVG icon component for footer social links.
public/icons/twitch.js	New Twitch SVG icon component for footer social links.
content/commons.json	Adds new footer literals for Bluesky/Twitch labels and URLs.
components/footer/Footer.jsx	Renders Bluesky and Twitch social buttons in the footer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-21T01:25:13Z

public/icons/bluesky.js

+    return (
+        <svg
+            className="icon-bluesky"
+            width="17"
+            height="17"
+            fill="none"
+            xmlns="http://www.w3.org/2000/svg"
+            viewBox="0 0 568 501"
+        >
+            <path
+                d="M123.121 33.6637C188.241 82.5526 258.281 181.681 284 234.873C309.719 181.681 379.759 82.5526 444.879 33.6637C491.866 -1.61183 568 -28.9064 568 57.9464C568 75.2916 558.055 203.659 552.222 224.501C531.947 296.954 458.067 315.434 392.347 304.249C507.222 323.8 536.444 388.56 473.333 453.32C353.473 576.312 301.061 422.461 287.631 383.039C285.169 375.812 284.017 372.431 284 375.306C283.983 372.431 282.831 375.812 280.369 383.039C266.939 422.461 214.527 576.312 94.6667 453.32C31.5556 388.56 60.7778 323.8 175.653 304.249C109.933 315.434 36.0535 296.954 15.7778 224.501C9.94525 203.659 0 75.2916 0 57.9464C0 -28.9064 76.1345 -1.61183 123.121 33.6637Z"
+                fill="white"
+            />
+        </svg>
+
+    )


This icon file uses 4-space indentation, which is inconsistent with the repo’s Prettier config (tabWidth: 2) and the other icon components in public/icons. Please reformat (or run Prettier) so indentation matches the established 2-space style to avoid noisy diffs later.

Suggested change

return (

<svg

className="icon-bluesky"

width="17"

height="17"

fill="none"

xmlns="http://www.w3.org/2000/svg"

viewBox="0 0 568 501"

>

<path

d="M123.121 33.6637C188.241 82.5526 258.281 181.681 284 234.873C309.719 181.681 379.759 82.5526 444.879 33.6637C491.866 -1.61183 568 -28.9064 568 57.9464C568 75.2916 558.055 203.659 552.222 224.501C531.947 296.954 458.067 315.434 392.347 304.249C507.222 323.8 536.444 388.56 473.333 453.32C353.473 576.312 301.061 422.461 287.631 383.039C285.169 375.812 284.017 372.431 284 375.306C283.983 372.431 282.831 375.812 280.369 383.039C266.939 422.461 214.527 576.312 94.6667 453.32C31.5556 388.56 60.7778 323.8 175.653 304.249C109.933 315.434 36.0535 296.954 15.7778 224.501C9.94525 203.659 0 75.2916 0 57.9464C0 -28.9064 76.1345 -1.61183 123.121 33.6637Z"

fill="white"

/>

</svg>

)

return (

<svg

className="icon-bluesky"

width="17"

height="17"

fill="none"

xmlns="http://www.w3.org/2000/svg"

viewBox="0 0 568 501"

>

<path

d="M123.121 33.6637C188.241 82.5526 258.281 181.681 284 234.873C309.719 181.681 379.759 82.5526 444.879 33.6637C491.866 -1.61183 568 -28.9064 568 57.9464C568 75.2916 558.055 203.659 552.222 224.501C531.947 296.954 458.067 315.434 392.347 304.249C507.222 323.8 536.444 388.56 473.333 453.32C353.473 576.312 301.061 422.461 287.631 383.039C285.169 375.812 284.017 372.431 284 375.306C283.983 372.431 282.831 375.812 280.369 383.039C266.939 422.461 214.527 576.312 94.6667 453.32C31.5556 388.56 60.7778 323.8 175.653 304.249C109.933 315.434 36.0535 296.954 15.7778 224.501C9.94525 203.659 0 75.2916 0 57.9464C0 -28.9064 76.1345 -1.61183 123.121 33.6637Z"

fill="white"

/>

</svg>

)

Copilot · 2026-03-21T01:25:13Z

public/icons/twitch.js

+    return (
+        <svg
+            className="icon-twitch"
+            xmlns="http://www.w3.org/2000/svg"
+            viewBox="0 0 2400 2800"
+            width="18"
+            height="18"
+            fill="none"
+        >
+            <g>
+                <g id="Layer_1-2">
+                    <path d="M500,0L0,500v1800h600v500l500-500h400l900-900V0H500z M2200,1300l-400,400h-400l-350,350v-350H600V200h1600
+                        V1300z" fill="white"/>
+                    <rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />
+                    <rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />
+                </g>
+            </g>
+        </svg>
+
+    )


This icon file uses 4-space indentation, which is inconsistent with the repo’s Prettier config (tabWidth: 2) and the other icon components in public/icons. Please reformat (or run Prettier) so indentation matches the established 2-space style to avoid noisy diffs later.

Suggested change

return (

<svg

className="icon-twitch"

xmlns="http://www.w3.org/2000/svg"

viewBox="0 0 2400 2800"

width="18"

height="18"

fill="none"

>

<g>

<g id="Layer_1-2">

<path d="M500,0L0,500v1800h600v500l500-500h400l900-900V0H500z M2200,1300l-400,400h-400l-350,350v-350H600V200h1600

V1300z" fill="white"/>

<rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />

<rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />

</g>

</g>

</svg>

)

return (

<svg

className="icon-twitch"

xmlns="http://www.w3.org/2000/svg"

viewBox="0 0 2400 2800"

width="18"

height="18"

fill="none"

>

<g>

<g id="Layer_1-2">

<path d="M500,0L0,500v1800h600v500l500-500h400l900-900V0H500z M2200,1300l-400,400h-400l-350,350v-350H600V200h1600

V1300z" fill="white"/>

<rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />

<rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />

</g>

</g>

</svg>

)

Copilot · 2026-03-21T01:25:13Z

public/icons/twitch.js

+                    <rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />
+                    <rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />


The footer hover styles only update svg path fills (see components/footer/footer.scss), but this SVG uses <rect> elements for the vertical bars. As a result, those bars won’t change color on hover and the icon will look inconsistent. Consider converting these rects to paths or updating the footer CSS to style rect fills as well.

Suggested change

<rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />

<rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />

<path d="M1700 550h200v600h-200z" className="st0" fill="white" />

<path d="M1150 550h200v600h-200z" className="st0" fill="white" />

Copilot · 2026-03-21T01:25:14Z

public/icons/twitch.js

+                    <rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />
+                    <rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />


className="st0" on these SVG elements doesn’t appear to be referenced anywhere in the repo. If it’s leftover from an SVG export, removing it would reduce noise and avoid implying there’s styling being applied.

Suggested change

<rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />

<rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />

<rect x="1700" y="550" width="200" height="600" fill="white" />

<rect x="1150" y="550" width="200" height="600" fill="white" />

TomNaughton and others added 7 commits December 11, 2025 21:05

Twitch icon added

f306f4f

Bluesky icon added and minor change to twitch icon

a8b6096

Update public/icons/bluesky.js

41f5cb5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update public/icons/bluesky.js

60df1fc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update public/icons/twitch.js

74ee04f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update public/icons/twitch.js

545150c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update public/icons/twitch.js

63d8331

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

abbycabs requested review from AndreaGriffiths11, LadyKerr and cassidoo as code owners March 21, 2026 01:22

Copilot AI review requested due to automatic review settings March 21, 2026 01:22

Copilot started reviewing on behalf of abbycabs March 21, 2026 01:22 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

abbycabs merged commit fa3e276 into main Mar 21, 2026
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contributors/tom naughton/269 add additional social icons#378

Contributors/tom naughton/269 add additional social icons#378
abbycabs merged 7 commits intomainfrom
contributors/TomNaughton/269-Add-additional-social-icons

abbycabs commented Mar 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		<rect x="1700" y="550" className="st0" width="200" height="600" fill="white" />
		<rect x="1150" y="550" className="st0" width="200" height="600" fill="white" />

Conversation

abbycabs commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abbycabs commented Mar 21, 2026 •

edited

Loading