Fix mcp-diff workflow triggers for push events and tags #1871
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add push triggers to run on: - Pushes to main branch (catches merges) - Tag pushes (v*) for release comparisons against previous tags The pull_request trigger alone doesn't run when commits are pushed to PR branches via merge or direct push. Adding push triggers ensures the diff runs in all expected scenarios.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MCP Server Diff GitHub Actions workflow to run not only on pull requests but also on key push events, ensuring diffs are generated for merges to main and tagged releases.
Changes:
- Adds a
pushtrigger on themainbranch so the MCP diff runs when PRs are merged. - Adds a
pushtrigger on tags matchingv*so the MCP diff runs on release tag pushes. - Keeps the existing
pull_requesttrigger so the workflow still runs on PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the MCP Server Diff workflow to trigger correctly in all expected scenarios.
Problem
The workflow was only triggered on
pull_requestevents, which doesn't run when:Solution
Added
pushtriggers for:branches: [main]- Runs when PRs are merged to maintags: ['v*']- Runs on tag pushes, enabling automatic comparison against the previous tag (e.g.,v1.2.0compares againstv1.1.0)This follows the recommended setup from mcp-server-diff documentation.
Testing
The workflow will now run on this PR via the existing
pull_requesttrigger, and will also run when merged to main or when releasing with tags.