fix: update get-me script for go-SDK MCP protocol #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go-SDK migration changed MCP protocol handling to require proper initialization before tool calls. This updates the script to: - Add initialize request with protocol version and client info - Add notifications/initialized notification - Add arguments field to tools/call params - Keep stdin open with sleep for response - Gracefully handle missing jq dependency
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the script/get-me test script to work with the updated go-SDK MCP protocol requirements. The go-SDK migration introduced proper protocol initialization requirements that the script was missing.
Key Changes
- Adds proper MCP protocol initialization sequence (initialize → notifications/initialized → tools/call)
- Adds the
argumentsfield to the tools/call request - Implements graceful handling for missing
jqdependency - Uses subshell pattern with
sleepto keep stdin open for server responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The go-SDK migration changed MCP protocol handling to require proper initialization before tool calls. The
script/get-mescript was broken as a result.Changes
Updates the script to:
initializerequest with protocol version and client infonotifications/initializednotificationargumentsfield totools/callparamssleepfor responsejqdependency (outputs raw JSON if jq not installed)Testing
GITHUB_PERSONAL_ACCESS_TOKEN=$(gh auth token) script/get-meReturns the authenticated user's profile information.