Mysql8 rename table#796
Open
raidivyansh074 wants to merge 5 commits intoabort-missing-backend-tablesfrom
Open
Conversation
| } | ||
| if this.migrationContext.CutOverType == base.CutOverAtomic { | ||
| var cutOverFunc func() error | ||
| if !mysql.IsSmallerMinorVersion(this.migrationContext.ApplierMySQLVersion, "8.0.13") { |
Collaborator
There was a problem hiding this comment.
@raidivyansh074 let's allow the user to decide if they want this style of cut-over, at least for now
Could you please add a new cut-over type the command line here and here
The check for mysql.IsSmallerMinorVersion could move to be a check at the start of the new cut-over type only
| return sql.NewColumnList(columnNames), sql.NewColumnList(virtualColumnNames), nil | ||
| } | ||
|
|
||
| func versionTokens(version string, digits int) []int { |
Collaborator
There was a problem hiding this comment.
@raidivyansh074 I suggest we use https://github.com/hashicorp/go-version for this instead so there is less code to maintain into the future
timvaillancourt
requested review from
a user,
meiji163,
rashiq and
timvaillancourt
timvaillancourt
requested changes
Dec 12, 2023
Collaborator
timvaillancourt
left a comment
timvaillancourt
left a comment
There was a problem hiding this comment.
@raidivyansh074 thanks for the PR 🙇. There are some inline changes requested
Also, could you please open an issue and update the summary with this + a description of what is being solved here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds traversing organizations you belong to for `git clone repo