Add support for MariaDB connection in configuration and URI generation#1552
Add support for MariaDB connection in configuration and URI generation#1552Vasanth-96 wants to merge 2 commits intogithub:masterfrom
Conversation
|
HI @rashiq @meiji163 @timvaillancourt could you guys review this pr and let me know if any more fix/changes need! |
|
Thanks for your PR @Vasanth-96! Ideally we should run the localtests on a MariaDB docker image. I'm not sure if there's one that works out of the box. |
|
Thanks for the suggestion, @meiji163 CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
f8ae17daf37b mariadb:10.3.31 "docker-entrypoint.s…" 6 days ago Up 6 days 0.0.0.0:3306->3306/tcp mariadb-container-fixThe fallback to tx_isolation is working as expected. |
|
@meiji163 please if you could checkout the reply comment thanks |
|
Given this comment #1488 (comment), perhaps we should should setting the connection variable directly instead of having a MariaDB flag |
|
It's back to |
A Pull Request should be associated with an Issue.
Related issue: #1488
#1488
Description
This PR addresses the issue encountered with MariaDB 10.3 when running gh-ost version 1.1.7. The error occurs due to the use of the transaction_isolation system variable, which is not present in MariaDB 10.3. Instead, MariaDB 10.3 uses tx_isolation to configure the transaction isolation level.
script/cibuildreturns with no formatting errors, build errors or unit test errors.attaching the images

