Notify waiting channels on completed transaction, not just the watermark#1531
Merged
meiji163 merged 7 commits intomeiji163/parallel-replfrom Apr 10, 2025
Merged
Notify waiting channels on completed transaction, not just the watermark#1531meiji163 merged 7 commits intomeiji163/parallel-replfrom
meiji163 merged 7 commits intomeiji163/parallel-replfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that waiting transactions are notified not only when the watermark increases but also when a transaction is completed. Key changes include:
- Extending the notification logic in coordinator.go to trigger on transaction completion.
- Updating the test suite in coordinator_test.go to simulate concurrent transactions using errgroup and randomize the number of inserts per transaction.
- Configuring additional connection limits in the test setup to support increased concurrency.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/logic/coordinator_test.go | Updated test logic for concurrent transaction simulation and setup. |
| go/logic/coordinator.go | Modified notification logic to include transaction completion conditions. |
meiji163
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends #1454 to notify waiting transactions not just when the watermark increases, but also when the transaction is completed.
script/cibuildreturns with no formatting errors, build errors or unit test errors.