Open
Conversation
Author
Author
|
tests still need to be expanded, but wanted to publish an initial revision for visibility |
Closed
Contributor
|
I hesitate to continue expanding the regex-based SQL parsing. If you need to compute the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new flag called "--create-table", an alternative to the "--alter" flag. With "--create-table" you can redefine the table that you want gh-ost to migrate to, effectively supporting what would have required multiple ALTERs.
For example, If you need to restructure the secondary indexes on a MySQL table, you would need to do the following:
Assuming a and b are already columns in the table...
xINT, ADD COLUMNyVARCHAR(24),ADD INDEX
a_x_idx(a,x),ADD INDEX
y_idx(y),DROP INDEX
a_b_idxNow you can simply provide a "--create-table" flag like so
The PR is a bit large as it includes some refactors to maintain code cleanliness. I can separate out some of the refactors into separate PRs for ease of review