Skip source GHES version check when the source host ends in ghe.com#1530
Draft
Skip source GHES version check when the source host ends in ghe.com#1530
ghe.com#1530Conversation
Co-authored-by: tambling <1431144+tambling@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-gei/sessions/08638412-bf30-47dd-8431-1023f8e36ec4
Copilot
AI
changed the title
[WIP] Skip source GHES version check for ghe.com hosts
Skip source GHES version check when the source host ends in Mar 20, 2026
ghe.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosts ending in
ghe.com(GitHub Enterprise Cloud with data residency) are not GHES instances and don't support theGetEnterpriseServerVersionAPI. The version checker now detectsghe.comhosts and skips the version check, returningfalseforAreBlobCredentialsRequired.Added
IsGheHosthelper usingUriparsing to check if the host ends with.ghe.comEarly return in
AreBlobCredentialsRequiredbefore callingGetEnterpriseServerVersionTwo new unit tests: return value correctness and verification that the API is never called
Did you write/update appropriate tests
Release notes updated (if appropriate)
Appropriate logging output
Issue linked
Docs updated (or issue created)
New package licenses are added to
ThirdPartyNotices.txt(if applicable)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.