[compiler-threat-spec] spec: fix CTR-018 implementation mapping filename and bump to v1.0.11#34559
Merged
pelikhan merged 1 commit intoMay 25, 2026
Conversation
The spec incorrectly referenced pkg/workflow/update_check_validation.go (which does not exist) for the CTR-018 Version Integrity Bypass rule. The actual implementation lives in pkg/workflow/strict_mode_update_check_validation.go and the test file is strict_mode_update_check_validation_test.go. - Correct Section 7.1 CTR-018 row: update_check_validation.go → strict_mode_update_check_validation.go - Correct test reference: update_check_validation_test.go → strict_mode_update_check_validation_test.go - Update Section 7.2 mapping audit date to 2026-05-25 - Bump spec version to 1.0.11 - Add Section 2 sync table entry for v1.0.11 - Add Section 10 change log entry for v1.0.11 Threats reviewed (2-day window, since 2026-05-23): - PR #34525: engine.permission-mode bypassPermissions decoupled from bash wildcard — documented security model behavior; no new CTR rule required. - CTR-001 through CTR-019: all implementation file references verified; only CTR-018 had a filename mismatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
deleted the
copilot/threat-spec-ctr018-mapping-fix-9a21282539971828
branch
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct CTR-018 implementation mapping and bump spec to v1.0.11
Summary
Fixes an incorrect implementation file mapping for threat control CTR-018 in the compiler threat-detection specification, and advances the spec to version 1.0.11.
Changes
specs/compiler-threat-detection-spec.md1.0.10→1.0.11What changed
update_check_validation.gotostrict_mode_update_check_validation.go, aligning the spec with the actual source file that implements this control.v1.0.11, documenting compatibility bounds for downstream consumers.1.0.11entry describing the mapping fix.Why it matters
An incorrect file reference in the threat-control mapping causes audit tooling and human reviewers to inspect the wrong source file when verifying CTR-018 coverage. This fix ensures traceability is accurate and the spec can be used reliably as a compliance artefact.
Testing
Documentation-only change. No code paths modified; no tests required.