codex: set default model to gpt-5.3-codex#34518
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Set default model for codex agentic engine to gpt-5.3-codex
codex: set default model to gpt-5.3-codex
May 24, 2026
Copilot created this pull request from a session on behalf of
pelikhan
May 24, 2026 18:49
View session
Collaborator
|
@copilot merge main and recompile |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done — merged main (branch was already up to date) and recompiled all 235 lock files. 9 codex workflows were updated to use |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR sets an explicit default model for the Codex engine (gpt-5.3-codex) so compiled workflows consistently pass a model when neither engine.model nor GH_AW_MODEL_AGENT_CODEX / GH_AW_MODEL_DETECTION_CODEX are set, and so GH_AW_INFO_MODEL reflects the real fallback model.
Changes:
- Add
constants.CodexDefaultModeland use it as the fallback for Codex agent + detection model env vars. - Update YAML lookup defaults so
GH_AW_INFO_MODELshows the Codex default rather than the generic"agent"label. - Update tests/golden normalization and regenerate golden/locked workflow outputs accordingly.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/engine_constants.go | Introduces CodexDefaultModel constant used as Codex fallback model. |
| pkg/workflow/codex_engine.go | Uses CodexDefaultModel when generating `${{ vars.* |
| pkg/workflow/compiler_yaml_lookups.go | Returns CodexDefaultModel as the default model display value for Codex in GH_AW_INFO_MODEL. |
| pkg/workflow/model_env_vars_test.go | Updates assertions to expect Codex default model fallback for agent + detection env vars. |
| pkg/workflow/wasm_golden_test.go | Normalizes Codex default-model fallback to keep wasm golden fixtures stable across future default bumps. |
| pkg/workflow/testdata/TestWasmGolden_AllEngines/codex.golden | Updates Codex golden output to match new defaults and regenerated output. |
| .github/workflows/smoke-codex.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/schema-feature-coverage.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/necromancer.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/issue-arborist.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/grumpy-reviewer.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/duplicate-code-detector.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/daily-cache-strategy-analyzer.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/codex-github-remote-mcp-test.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
| .github/workflows/ai-moderator.lock.yml | Regenerated lock workflow to reflect Codex default model fallback in env/run info. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 15/15 changed files
- Comments generated: 1
Comment on lines
368
to
378
| // Set the model environment variable. | ||
| // Codex has no native model env var, so model selection always goes through | ||
| // GH_AW_MODEL_AGENT_CODEX / GH_AW_MODEL_DETECTION_CODEX with shell expansion. | ||
| // When model is configured (static or GitHub Actions expression), set the env var directly. | ||
| // When not configured, use the GitHub variable fallback so users can set a default. | ||
| if modelConfigured { | ||
| codexEngineLog.Printf("Setting %s env var for model: %s", modelEnvVar, workflowData.EngineConfig.Model) | ||
| env[modelEnvVar] = workflowData.EngineConfig.Model | ||
| } else { | ||
| env[modelEnvVar] = fmt.Sprintf("${{ vars.%s || '' }}", modelEnvVar) | ||
| env[modelEnvVar] = fmt.Sprintf("${{ vars.%s || '%s' }}", modelEnvVar, constants.CodexDefaultModel) | ||
| } |
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codex engine had no default model — when
engine.modelwas unset andGH_AW_MODEL_AGENT_CODEX/GH_AW_MODEL_DETECTION_CODEXvariables were absent, the fallback was an empty string (causing no--modelflag) andGH_AW_INFO_MODELshowed the generic label"agent".Changes
pkg/constants/engine_constants.go— addsCodexDefaultModel = "gpt-5.3-codex", parallel toCopilotBYOKDefaultModelpkg/workflow/codex_engine.go— usesCodexDefaultModelas the||fallback in the generated env var expression:pkg/workflow/compiler_yaml_lookups.go—getDefaultAgentModel("codex")returnsCodexDefaultModelinstead of"agent", soGH_AW_INFO_MODELreflects the actual modelpkg/workflow/model_env_vars_test.go— updates agent and detection job assertions to expectgpt-5.3-codexfallbackpkg/workflow/wasm_golden_test.go— addsCodexDefaultModelnormalization (mirrorsCopilotBYOKDefaultModelhandling) to keep golden fixtures stable across future default-model bumpscodex.golden— regenerated; also picks up two pre-existing golden diffs (regex-anchoredinclude_onlyenv names, removal of-c fetch="disabled") that were already failing onmainbefore this PR