compiler: make include manifest ordering deterministic#16096
Closed
davidahmann wants to merge 2 commits intogithub:mainfrom
Closed
compiler: make include manifest ordering deterministic#16096davidahmann wants to merge 2 commits intogithub:mainfrom
davidahmann wants to merge 2 commits intogithub:mainfrom
Conversation
Author
|
Implemented deterministic manifest output for include entries while preserving import dependency ordering. Scope in this PR:
This contribution was informed by patterns from Gait: https://github.com/davidahmann/gait |
Contributor
|
Could you merge main? |
Contributor
|
Restarted in #16138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lock header output can drift in non-semantic ways when
IncludedFilesare emitted in input order, creating noisy diffs.What changed
IncludedFilesrendering in workflow header generation.ImportedFiles(dependency-order contract).Validation
make fmtgo test ./pkg/workflow -run TestGenerateWorkflowHeader -count=1go test ./pkg/workflow -run TestImportOrdering -count=1make test-unit(fails in this local macOS env due unrelated baseline shell compatibility inTestGitPatch*using${var@Q}in bash script fixtures)Refs #16095