-
Notifications
You must be signed in to change notification settings - Fork 111
Add git credentials cleanup and regeneration for agent execution #14700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot run |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
🔍 PR Triage ResultsCategory: chore | Risk: high | Priority: 29/100 Scores Breakdown
📋 Recommended Action: DEFERConcerns:
Recommendation: Defer until:
Next Steps:
Triaged by PR Triage Agent on 2026-02-10 00:45 UTC
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
✅ Changeset Generator completed successfully! |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🧪 Smoke Project is now testing project operations... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Agent Container Tool Check
Result: 10/12 tools fully functional, 2/12 with execution issues Notes:
|
|
✅ Smoke Project completed successfully. All project operations validated. |
|
PR titles: Apply strict matching to slash commands (startsWith + exact equality); Fix API key masking timing vulnerability in MCP setup generation
|
Smoke Test Results: ✅ PASSLast 2 Merged PRs:
Tests: ✅ GitHub MCP | ✅ Safe Inputs GH CLI | ✅ Serena MCP | ✅ Playwright | ✅ File Writing | ✅ Bash | ✅ Discussion Comment | ✅ Build | ✅ Workflow Dispatch Overall: All 9 tests passed @pelikhan
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Prevents agents from accessing git credentials during execution while preserving safe-outputs functionality by cleaning credentials before agent execution and regenerating them afterwards.
Implementation
Cleanup Script (
actions/setup/sh/clean_git_credentials.sh):[credential]sections and URL-specific credential configshttp.extraheader(used byactions/checkout)https://user:pass@host→https://host)originremote (does NOT remove it)Compiler Integration (
pkg/workflow/compiler_yaml_main_job.go):generateEngineExecutionSteps()generateGitConfigurationSteps()again)Helper Function (
pkg/workflow/yaml_generation.go):Workflow Flow
${{ github.token }}This approach protects credentials from the agent while preserving functionality for safe-outputs operations like
create_pull_requestandpush_to_pull_request_branchthat depend ongit fetch originandgenerate_git_patch.cjs.All 148 workflows recompiled with cleanup and regeneration steps positioned correctly.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Changeset
Changeset