Skip to content

[log] Add debug logging to DIFC policy helper functions #6501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Draft

[log] Add debug logging to DIFC policy helper functions #6501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/server/difc_log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ const maxFilteredItemsInNotice = 5
// The heuristic: tools with the "list_" or "search_" prefix are collection tools;
// everything else (get_*, *_read, etc.) is treated as a singular read.
func isSingularReadTool(toolName string) bool {
return !strings.HasPrefix(toolName, "list_") && !strings.HasPrefix(toolName, "search_")
singular := !strings.HasPrefix(toolName, "list_") && !strings.HasPrefix(toolName, "search_")
logDifcLog.Printf("isSingularReadTool: toolName=%s, singular=%v", toolName, singular)
return singular
}

// buildDIFCSingleItemFilteredError constructs an error for when exactly one item is
Expand All @@ -140,6 +142,7 @@ func buildDIFCSingleItemFilteredError(detail difc.FilteredItemDetail) error {
if detail.Reason != "" {
msg = fmt.Sprintf("%s (%s)", msg, detail.Reason)
}
logDifcLog.Printf("buildDIFCSingleItemFilteredError: description=%s, policy=%s, reason=%s", desc, policyLabel, detail.Reason)
return fmt.Errorf("%s", msg)
}

Expand Down Expand Up @@ -216,6 +219,7 @@ func difcPolicyLabel(items []difc.FilteredItemDetail) string {
integrityCount++
}
}
logDifcLog.Printf("difcPolicyLabel: total=%d, secrecyViolations=%d, integrityViolations=%d", len(items), secrecyCount, integrityCount)
switch {
case secrecyCount > 0 && integrityCount == 0:
return "secrecy policy"
Expand Down