Skip to content

Remove unused export from ProbeResult interface#3584

Merged
lpcox merged 2 commits into
mainfrom
copilot/remove-unused-probe-result-interface
May 22, 2026
Merged

Remove unused export from ProbeResult interface#3584
lpcox merged 2 commits into
mainfrom
copilot/remove-unused-probe-result-interface

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

ProbeResult in src/dind-probe.ts was exported but never imported by any other module — it exists solely as the internal return type of probeSplitFilesystem.

Change

  • src/dind-probe.ts: Drop export from the ProbeResult interface declaration.
// Before
export interface ProbeResult { ... }

// After
interface ProbeResult { ... }

Keeps the public API surface minimal and removes a type that callers could mistakenly depend on instead of inferring the return type directly.

Copilot AI changed the title [WIP] Remove unused exported interface ProbeResult Remove unused export from ProbeResult interface May 22, 2026
Copilot AI requested a review from lpcox May 22, 2026 14:33
Copilot finished work on behalf of lpcox May 22, 2026 14:33
@lpcox lpcox marked this pull request as ready for review May 22, 2026 14:40
Copilot AI review requested due to automatic review settings May 22, 2026 14:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 95.98% 96.05% 📈 +0.07%
Statements 95.81% 95.87% 📈 +0.06%
Functions 98.02% 98.02% ➡️ +0.00%
Branches 89.44% 89.48% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/config-writer.ts 83.0% → 85.6% (+2.54%) 83.0% → 85.6% (+2.54%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions
Copy link
Copy Markdown
Contributor

✅ Smoke test passed

  • GitHub API: 2 PR entries verified
  • Playwright check: PASS
  • File verification: OK

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP connectivity ✅ PR #3567 fetched successfully
GitHub.com HTTP ⚠️ Pre-step template not expanded
File write/read ⚠️ Pre-step template not expanded
BYOK inference (this response)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: PARTIAL PASS — BYOK inference and MCP work; pre-step data unavailable (template vars unexpanded).

PR by @Copilot, assignees: @lpcox, @Copilot.

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Smoke Test Results

Test Result
GitHub MCP connectivity ✅ PR data fetched successfully
GitHub.com HTTP connectivity ✅ Reachable
File write/read smoke-test-copilot-26293869892.txt verified

Overall: PASS

PR: "Remove unused export from ProbeResult interface" — @Copilot | Assignees: @lpcox, @Copilot

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Sync source AWF schema copy with documented schema
Refactor token usage record/metrics construction into shared token-persistence helpers
GitHub PR review ✅ | safeinputs-gh ❌ | Playwright ✅ | Tavily ❌
File/Bash ✅ | Discussion ❌ | Build ✅
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Version Comparison — Smoke Test Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ NO
Node.js v24.15.0 v22.22.3 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: FAIL. 1/2 PRs found. Connectivity ❌. File writing ✅. Bash ✅.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results — FAIL

  • ❌ Redis: connection timed out (no response from host.docker.internal:6379)
  • ❌ PostgreSQL pg_isready: no response on host.docker.internal:5432
  • ❌ PostgreSQL SELECT 1: skipped (pg_isready failed)

Overall: FAILhost.docker.internal is not reachable from this runner environment. Service containers may not be configured or the host alias is not resolvable.

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3584 · ● 7.3M ·

@lpcox lpcox merged commit ac64d63 into main May 22, 2026
65 of 70 checks passed
@lpcox lpcox deleted the copilot/remove-unused-probe-result-interface branch May 22, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Unused exported interface ProbeResult in src/dind-probe.ts

3 participants