-
Notifications
You must be signed in to change notification settings - Fork 1
Auth via Gh App #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth via Gh App #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds GitHub App authentication support to the deployment tracker, allowing authentication via GitHub App credentials instead of only Personal Access Tokens (PATs). When both authentication methods are configured, the GitHub App takes precedence.
Changes:
- Added GitHub App authentication using the
ghinstallationpackage for automatic token management - Introduced three new environment variables for GitHub App configuration (app ID, installation ID, and private key path)
- Updated documentation to describe both PAT and GitHub App authentication methods
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/deploymentrecord/client.go | Added WithGHApp option and transport field; updated PostOne to prioritize GitHub App authentication |
| internal/controller/controller.go | Added logic to configure GitHub App client options when credentials are present |
| internal/controller/config.go | Added three new config fields for GitHub App credentials |
| go.mod | Added dependencies for GitHub App authentication (ghinstallation, golang-jwt, go-github) |
| cmd/deployment-tracker/main.go | Added environment variable loading for GitHub App credentials |
| README.md | Updated documentation with authentication section and GitHub App environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
indigok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
This PR adds support for authenticating with a GitHub App instead of a PAT. If both are provided, the GitHub App takes precedence.
The used package for token management automatically takes care of token renewal, and is thread safe.