Skip to content

Conversation

@aaronpowell
Copy link
Contributor

No description provided.

@aaronpowell aaronpowell requested a review from a team as a code owner January 22, 2026 22:12
Copilot AI review requested due to automatic review settings January 22, 2026 22:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the explicit PublishAot=false override from the .NET cookbook “file-based app” recipes so they no longer opt out of AOT publishing.

Changes:

  • Removed #:property PublishAot=false from each cookbook recipe .cs file so AOT can be enabled when publishing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
cookbook/dotnet/recipe/pr-visualization.cs Removes the directive that forced PublishAot=false.
cookbook/dotnet/recipe/persisting-sessions.cs Removes the directive that forced PublishAot=false.
cookbook/dotnet/recipe/multiple-sessions.cs Removes the directive that forced PublishAot=false.
cookbook/dotnet/recipe/managing-local-files.cs Removes the directive that forced PublishAot=false.
cookbook/dotnet/recipe/error-handling.cs Removes the directive that forced PublishAot=false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
// Note: AOT is enabled by default for this recipe.
// To disable AOT (for example, during local development), add:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:property PublishAot=false

Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
// Note: AOT is enabled by default. To disable AOT for this recipe, add:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:property PublishAot=false

Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
// Note: AOT (PublishAot) is enabled by default for this recipe.
// To disable AOT, add the following directive above:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:property PublishAot=false

Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
// NOTE: This recipe publishes with Native AOT enabled by default.
// To disable AOT for this recipe (for example, if you hit platform or tooling
// limitations), add the following directive at the top of this file:
//
// #:property PublishAot=false
//
// This overrides the default and publishes a non-AOT binary instead.

Copilot uses AI. Check for mistakes.
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
// Note: AOT (PublishAot) is enabled by default for this recipe.
// To disable AOT for this sample, you can add the directive:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant