Skip to content

chore: optimize devcontainer for Codespaces prebuilds #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanWahlin merged 1 commit into from
Apr 6, 2026
Merged

chore: optimize devcontainer for Codespaces prebuilds #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
]
}
},
"onCreateCommand": "pip install pytest && npm install -g @github/copilot && gh extension install github/gh-copilot",
"onCreateCommand": "pip install pytest && npm install -g @github/copilot && (gh extension install github/gh-copilot || true)",
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says install commands were moved from postCreateCommand to onCreateCommand, but this diff only modifies an existing onCreateCommand (there is no postCreateCommand in the file/repo). Please update the PR description (or the config) so it accurately reflects the actual change being made.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using (gh extension install github/gh-copilot || true) will silently ignore any install failure (network issues, GitHub CLI auth issues, etc.), which can leave gh copilot unavailable on older GH CLI versions without any signal. Prefer gating the install (e.g., only run it if gh copilot --help fails) or handling only the specific built-in-command conflict instead of swallowing all errors.

Suggested change
"onCreateCommand": "pip install pytest && npm install -g @github/copilot && (gh extension install github/gh-copilot || true)",
"onCreateCommand": "pip install pytest && npm install -g @github/copilot && (gh copilot --help >/dev/null 2>&1 || gh extension install github/gh-copilot)",

Copilot uses AI. Check for mistakes.
"postStartCommand": "echo '✅ Python, pytest, GitHub CLI, and Copilot CLI are ready. Run: cd samples/book-app-project && python book_app.py help'"
}
Loading