Skip to content

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Nov 24, 2025

In this PR we

@github-actions github-actions bot added the C# label Nov 24, 2025
@michaelnebel michaelnebel force-pushed the csharp/dotnet10extractor branch 10 times, most recently from 5bbbb72 to 83afda0 Compare December 1, 2025 09:41
@michaelnebel michaelnebel force-pushed the csharp/dotnet10extractor branch 5 times, most recently from 1bcd53c to 45ce20d Compare December 8, 2025 15:37
@michaelnebel michaelnebel force-pushed the csharp/dotnet10extractor branch from 45ce20d to 71ebbfe Compare December 9, 2025 10:53
@michaelnebel michaelnebel changed the title C#: Build extractor using .NET 10. C#: Use .NET 10 for building the extractor and running tests. Dec 9, 2025
@michaelnebel michaelnebel marked this pull request as ready for review December 9, 2025 14:59
@michaelnebel michaelnebel requested a review from a team as a code owner December 9, 2025 14:59
Copilot AI review requested due to automatic review settings December 9, 2025 14:59
@michaelnebel michaelnebel requested review from a team as code owners December 9, 2025 14:59
@michaelnebel michaelnebel requested a review from hvitved December 9, 2025 15:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the C# extractor and testing infrastructure from .NET 9 to .NET 10, including updates to build tooling, integration tests, and test stubs.

  • Updates .NET SDK from 9.0.300/9.0.304 to 10.0.100
  • Upgrades Bazel rules_dotnet to 0.21.5 with custom patches
  • Migrates target framework from net9.0 to net10.0 across all projects and tests

Reviewed changes

Copilot reviewed 297 out of 301 changed files in this pull request and generated no comments.

Show a summary per file
File Description
misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/source.json Updates rules_dotnet source URL and integrity hash to version 0.21.5
misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/MODULE.bazel Adds new MODULE.bazel configuration for rules_dotnet 0.21.5 with .NET 10.0.100 toolchain
misc/bazel/registry/modules/rules_dotnet/0.19.2-codeql.1/MODULE.bazel Removes obsolete MODULE.bazel for rules_dotnet 0.19.2
misc/bazel/csharp.bzl Updates TARGET_FRAMEWORK constant from net9.0 to net10.0
csharp/scripts/stubs/helpers.py Updates stub generation scripts to use .NET 10 SDK and target framework
csharp/scripts/gen-assembly-info.py Updates assembly info to reference .NET 10.0 instead of 9.0
csharp/scripts/create-extractor-pack.sh Updates RuntimeFrameworkVersion to 10.0.0 for publishing
csharp/ql/test/utils/modeleditor/ApplicationModeEndpoints.expected Updates expected test output from version 9.0.0.0 to 10.0.0.0
csharp/ql/test/resources/stubs/**/*.csproj Updates target framework from net9.0 to net10.0 in test stub projects
csharp/ql/test/library-tests/**/*.expected Updates expected test outputs to reflect .NET 10 assembly versions
csharp/ql/lib/change-notes/2025-12-09-bmn-default-dotnet.md Adds change note documenting .NET 10 as default for build mode: none
csharp/ql/integration-tests/**/*.csproj Updates target framework from net9.0 to net10.0 in integration test projects
csharp/ql/integration-tests/**/global.json Updates SDK version from 9.0.304 to 10.0.100 in integration tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelnebel
Copy link
Contributor Author

@redsun82 : It looks like we need to re-apply the patch for dotnet_rules. Do you think it makes sense to get patch into rules_dotnet main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant