-
Notifications
You must be signed in to change notification settings - Fork 1.9k
C#: Use .NET 10 for building the extractor and running tests. #20898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5bbbb72 to
83afda0
Compare
1bcd53c to
45ce20d
Compare
45ce20d to
71ebbfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the C# extractor and testing infrastructure from .NET 9 to .NET 10, including updates to build tooling, integration tests, and test stubs.
- Updates .NET SDK from 9.0.300/9.0.304 to 10.0.100
- Upgrades Bazel rules_dotnet to 0.21.5 with custom patches
- Migrates target framework from net9.0 to net10.0 across all projects and tests
Reviewed changes
Copilot reviewed 297 out of 301 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/source.json | Updates rules_dotnet source URL and integrity hash to version 0.21.5 |
| misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/MODULE.bazel | Adds new MODULE.bazel configuration for rules_dotnet 0.21.5 with .NET 10.0.100 toolchain |
| misc/bazel/registry/modules/rules_dotnet/0.19.2-codeql.1/MODULE.bazel | Removes obsolete MODULE.bazel for rules_dotnet 0.19.2 |
| misc/bazel/csharp.bzl | Updates TARGET_FRAMEWORK constant from net9.0 to net10.0 |
| csharp/scripts/stubs/helpers.py | Updates stub generation scripts to use .NET 10 SDK and target framework |
| csharp/scripts/gen-assembly-info.py | Updates assembly info to reference .NET 10.0 instead of 9.0 |
| csharp/scripts/create-extractor-pack.sh | Updates RuntimeFrameworkVersion to 10.0.0 for publishing |
| csharp/ql/test/utils/modeleditor/ApplicationModeEndpoints.expected | Updates expected test output from version 9.0.0.0 to 10.0.0.0 |
| csharp/ql/test/resources/stubs/**/*.csproj | Updates target framework from net9.0 to net10.0 in test stub projects |
| csharp/ql/test/library-tests/**/*.expected | Updates expected test outputs to reflect .NET 10 assembly versions |
| csharp/ql/lib/change-notes/2025-12-09-bmn-default-dotnet.md | Adds change note documenting .NET 10 as default for build mode: none |
| csharp/ql/integration-tests/**/*.csproj | Updates target framework from net9.0 to net10.0 in integration test projects |
| csharp/ql/integration-tests/**/global.json | Updates SDK version from 9.0.304 to 10.0.100 in integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@redsun82 : It looks like we need to re-apply the patch for |
In this PR we
rules_dotnettil0.21.5with our patch on top (required for running unit tests).10(alpha)paketfor managing NuGet dependencies. In any case - this is not a blocker and we shouldn't disable the warning (for now).