C#: Exclude enum types as they don't inherit the default toString. #20442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the C# CodeQL query cs/call-to-object-tostring by excluding enum types from the default toString analysis to reduce false positives. Enum types have their own overridden toString implementation that provides meaningful output (the enum value name), so they should not be flagged as using the default Object.toString() method.
- Excludes enum types from the default toString detection logic
- Adds a change note documenting the false positive reduction
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DefaultToStringQuery.qll | Adds exclusion for enum types in the alwaysDefaultToString predicate |
| 2025-09-16-default-tostring-enum.md | Documents the improvement in reducing false positives for enum types |
hvitved
approved these changes
Sep 16, 2025
Contributor
Author
|
Ignoring irrelevant integration test issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor drive-by FP removal improvement.