Cargo: align rust toolchain version with internal repository #20207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * remove new warnings raised by the rust toolchain * run new formatting and linting * update the rust toolchain used by `cargo` While we keep `bazel` builds using the same toolchain as internally (now a nightly one), I opted for using a stable toolchain for `cargo`. The nightly toolchain is only required internally for build reasons, we should keep not using any unstable rust features in our sources.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the Rust toolchain version with the internal repository by updating to a nightly toolchain for Bazel builds while using a stable toolchain for Cargo development. The changes include updating the Rust version from 1.86 to nightly/2025-08-01 for Bazel, creating a separate stable toolchain (1.88) for Cargo, and applying formatting and linting fixes required by the new toolchain.
Key changes:
- Updated Rust toolchain from stable 1.86 to nightly 2025-08-01 for Bazel builds
- Created separate toolchain configuration for Cargo using stable 1.88
- Applied formatting improvements throughout Rust codebase
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updated to use stable Rust 1.88 for Cargo development |
| rust/rust-toolchain.toml | Removed (consolidated into root toolchain file) |
| MODULE.bazel | Updated to nightly Rust toolchain with new SHA256 hashes |
| .bazelrc | Added nightly toolchain configuration and linker settings |
| shared/tree-sitter-extractor/src/generator/ql_gen.rs | Applied lifetime annotations and formatting improvements |
| shared/tree-sitter-extractor/src/generator/mod.rs | Applied formatting improvements |
| rust/extractor/src/trap.rs | Updated string formatting to use inline syntax |
| rust/extractor/src/translate/base.rs | Updated string formatting to use inline syntax |
| rust/extractor/src/rust_analyzer.rs | Updated string formatting and added lifetime annotations |
| rust/ast-generator/src/main.rs | Updated string formatting and error messages |
navntoft
previously approved these changes
Aug 12, 2025
Contributor
Author
|
@navntoft mind looking at this again? I hadn't noticed that a |
navntoft
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
cargoWhile we keep
bazelbuilds using the same toolchain as internally (now a nightly one), I opted for using a stable toolchain forcargo. The nightly toolchain is only required internally for build reasons, we should keep not using any unstable rust features in our sources.Finally, we aren't ready yet to update the rust toolchain used in rust language tests, so I've pulled that out in its own
rust-toolchainfile, keeping it at 1.86 for the time being.