C#: Include constructors in ValueOrRefType.hasCallable
#20158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
reviewed
Aug 4, 2025
Comment on lines
204
to
208
| this.hasMethod(c) | ||
| or | ||
| this.hasMember(c.(Accessor).getDeclaration()) | ||
| or | ||
| c = this.getAConstructor() |
Contributor
There was a problem hiding this comment.
Alternatively replace hasMethod in the first line of the predicate with hasMember - I think that's equivalent.
Contributor
Author
There was a problem hiding this comment.
Yeah, good point, that is simpler.
aschackmull
previously approved these changes
Aug 4, 2025
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
A minor comment - take it or leave it. LGTM.
hvitved
force-pushed
the
csharp/has-callable-constructor
branch
from
554386d to
361ef0f
Compare
aschackmull
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.