C#: Make web.config match case insensitive (with change note) #20065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the C# CodeQL library to make web.config file matching case insensitive. Previously, only files with exact case matches (e.g., "Web.config") were recognized, but now files with any case variation (e.g., "web.config", "WEB.CONFIG") will be detected.
- Modifies web.config file detection to use case-insensitive matching
- Updates both standard web.config and web.release.config file patterns
- Adds a change note documenting the fix and its impact on existing queries
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/ql/src/change-notes/2025-07-16-web-config.md | Documents the case insensitive matching fix and query impact |
| csharp/ql/lib/semmle/code/asp/WebConfig.qll | Implements case insensitive file name matching using toLowerCase() |
michaelnebel
approved these changes
Jul 16, 2025
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
Excellent - thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variant of #20061 with a change note