Ruby/QL: add discard predicates for locations #19963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrolfe
force-pushed
the
nickrolfe/overlay-deleted-files
branch
from
b6d49dc to
2ac7bf8
Compare
nickrolfe
force-pushed
the
nickrolfe/rb-discard-locations
branch
from
cacc1c9 to
3a0c7bc
Compare
nickrolfe
force-pushed
the
nickrolfe/overlay-deleted-files
branch
from
2ac7bf8 to
d8574a6
Compare
nickrolfe
force-pushed
the
nickrolfe/rb-discard-locations
branch
from
3a0c7bc to
281d5cd
Compare
nickrolfe
force-pushed
the
nickrolfe/rb-discard-locations
branch
from
281d5cd to
7c5b186
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tree-sitter-based extractors use
*IDs for locations, they are not shared between a base database and an overlay, so we need to adddiscard_entitypredicates to discard locations from the base in files that got re-extracted in the overlay.