Skip to content

C++: Fix VariableAddress instruction association for unnamed parameters #19941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IdrissRio wants to merge 1 commit into from
Closed

C++: Fix VariableAddress instruction association for unnamed parameters #19941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedFunction.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,12 @@ class TranslatedParameterReadEffect extends TranslatedReadEffect, TTranslatedPar
}

final override IRVariable getInstructionVariable(InstructionTag tag) {
tag = OnlyInstructionTag() and
(
tag = OnlyInstructionTag() or
tag = InitializerStoreTag() or
tag = InitializerVariableAddressTag() or
tag = InitializerIndirectStoreTag()
) and
Comment on lines +860 to +865
Copy link
Contributor

@jketema jketema Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not being clear enough. This is a problem on the extractor side. This should not be fixed here.

result = getIRUserVariable(this.getFunction(), param)
}
}