Rust: Assume prelude is always available in path resolution #19936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/path-resolution-prelude-always
branch
2 times, most recently
from
1dd2cf5 to
d3bf010
Compare
hvitved
force-pushed
the
rust/path-resolution-prelude-always
branch
from
d3bf010 to
bd1f46b
Compare
geoffw0
reviewed
Jul 1, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Is the goal here mainly to reduce inconsistencies?
Contributor
Author
The goal is to resolve more paths; I have seen cases where the prelude was not correctly taken into account, which this PR resolves. |
geoffw0
approved these changes
Jul 1, 2025
Contributor
|
I forgot to look at DCA before approving - significantly more sinks are found which is great, and probably explained by resolving more paths 🎉. We also find more call targets and have fewer type inference inconsistencies 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be safe to assume that the prelude is always available, since shadowing definitions will be prioritized anyway, so this PR removes the crate-dependency restriction.
DCA looks great:
windows-rs, in particular, has a high increase in resolvable calls (from 11 % to 33 %).