Skip to content

Rust: make AssocItem and ExternItem subclasses of Item #19873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvitved merged 9 commits into from
Jul 1, 2025
Merged

Rust: make AssocItem and ExternItem subclasses of Item #19873

hvitved merged 9 commits into from
Jul 1, 2025

Conversation

@redsun82
Copy link
Contributor

@redsun82 redsun82 commented Jun 25, 2025

No description provided.

@github-actions github-actions bot added Rust Pull requests that update Rust code Swift labels Jun 25, 2025
@github-actions github-actions bot removed the Swift label Jun 30, 2025
@redsun82 redsun82 marked this pull request as ready for review June 30, 2025 12:57
Copilot AI review requested due to automatic review settings June 30, 2025 12:57
@redsun82 redsun82 requested a review from a team as a code owner June 30, 2025 12:57
Copilot AI reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

aibaars
aibaars reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@redsun82 redsun82 requested a review from aibaars June 30, 2025 15:10
@hvitved hvitved merged commit 2ee3401 into main Jul 1, 2025
21 checks passed
@hvitved hvitved deleted the redsun82/rust-item-reorg branch July 1, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@aibaars aibaars aibaars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@redsun82 @aibaars @hvitved