Skip to content

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jun 23, 2025

It looks like this query might produce a lot more results for BMN databases compared to traced databases. Excluding it from the Code Quality suite for now.

Follow up of #19799

@github-actions github-actions bot added the Java label Jun 23, 2025
@michaelnebel michaelnebel marked this pull request as ready for review June 23, 2025 09:48
Copilot AI review requested due to automatic review settings June 23, 2025 09:48
@michaelnebel michaelnebel requested a review from a team as a code owner June 23, 2025 09:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the java/deprecated-call query from the Code Quality suites and updates related metadata.

  • Drop the quality tag from the AvoidDeprecatedCallableAccess.ql metadata.
  • Remove references to the deprecated query in both integration-test expectation files.
  • Keep test numbering and other entries unchanged.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql Removed the quality tag from the @tags list
java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected Deleted the line excluding the deprecated query
java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected Deleted the line excluding the deprecated query

@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Jun 23, 2025
@michaelnebel michaelnebel merged commit 725ba28 into github:main Jun 23, 2025
20 of 21 checks passed
@owen-mc
Copy link
Contributor

owen-mc commented Jun 23, 2025

It's probably worth referencing the original PR where this query was added to the code quality suite, to make it easier to find this PR in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants