Skip to content

Ruby: mass enable diff-informed data flow none() location overrides #19798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d10c merged 1 commit into from
Jun 19, 2025
Merged

Ruby: mass enable diff-informed data flow none() location overrides #19798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ruby/ql/src/experimental/manually-check-http-verb/ManuallyCheckHttpVerb.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ private module HttpVerbConfig implements DataFlow::ConfigSig {
}

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSourceLocation(DataFlow::Node source) { none() }
}

private module HttpVerbFlow = TaintTracking::Global<HttpVerbConfig>;
Expand Down
2 changes: 2 additions & 0 deletions ruby/ql/src/experimental/weak-params/WeakParams.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ private module WeakParamsConfig implements DataFlow::ConfigSig {
predicate isSink(DataFlow::Node node) { node = any(PersistentWriteAccess a).getValue() }

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSourceLocation(DataFlow::Node source) { none() }
}

private module WeakParamsFlow = TaintTracking::Global<WeakParamsConfig>;
Expand Down
2 changes: 2 additions & 0 deletions ruby/ql/src/queries/meta/TaintedNodes.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ private module BasicTaintConfig implements DataFlow::ConfigSig {
}

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSourceLocation(DataFlow::Node source) { none() }
}

Comment on lines +24 to 27
Copy link

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This override is duplicated across multiple config modules; consider extracting it into a shared mixin or trait to reduce repetition.

Suggested change
Location getASelectedSourceLocation(DataFlow::Node source) { none() }
}
private module SharedTaintConfig {
Location getASelectedSourceLocation(DataFlow::Node source) { none() }
}
private module BasicTaintConfig implements DataFlow::ConfigSig, SharedTaintConfig {
}

Copilot uses AI. Check for mistakes.
private module BasicTaintFlow = TaintTracking::Global<BasicTaintConfig>;
Expand Down
Loading