Ruby: Update quality tags. #19793
Ruby: Update quality tags. #19793
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the metadata tags for two Ruby QL queries to better align with the style guide and records the changes in the project documentation.
- Reorder and add the
useless-codetag to theDeadStoreOfLocal.qlquery - Reorder and add the
reliabilitytag to theDatabaseQueryInLoop.qlquery - Document both tag updates in
2025-06-17-tagging.md
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ruby/ql/src/queries/variables/DeadStoreOfLocal.ql | Reordered @tags list and added useless-code |
| ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql | Reordered @tags list and added reliability |
| ruby/ql/src/2025-06-17-tagging.md | Added entry describing the updated metadata tags |
Comments suppressed due to low confidence (1)
ruby/ql/src/2025-06-17-tagging.md:4
- [nitpick] It may be helpful to list each query and its specific tag changes (e.g., old vs. new tags) for clearer context and future reference.
* Update query metadata tags for `rb/database-query-in-loop` and `rb/useless-assignment-to-local` to align with the established
| * @tags quality | ||
| * maintainability | ||
| * useless-code | ||
| * external/cwe/cwe-563 |
There was a problem hiding this comment.
[nitpick] Consider ordering the tags either alphabetically or according to the style guide’s recommended sequence for readability and consistency.
| * @tags quality | |
| * maintainability | |
| * useless-code | |
| * external/cwe/cwe-563 | |
| * @tags external/cwe/cwe-563 | |
| * maintainability | |
| * quality | |
| * useless-code |
| * @tags quality | ||
| * reliability | ||
| * performance |
There was a problem hiding this comment.
[nitpick] Similar to the first query, ensure the tag order follows the established style guide to keep all queries consistent.
| * @tags quality | |
| * reliability | |
| * performance | |
| * @tags performance | |
| * quality | |
| * reliability |
michaelnebel
force-pushed
the
ruby/qualitytags
branch
from
cb232a9 to
08d28a5
Compare
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
We should turn those rules into a QL4QL query.
Yes, that is a good idea. It is already on my list 😄 |
2 participants
No description provided.