Rust: ignore target in qltest
#19542
Conversation
The target file created by `cargo check` was causing problems in language tests. We might want to also ignore `target` by default in the production indexing, but I'll leave that for further discussion.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the qltest extractor to skip target directories when collecting test source files, preventing build artifacts from being included in language tests.
- Adds a filter to exclude paths starting with
target - Ensures errors during globbing still propagate correctly
Comments suppressed due to low confidence (1)
rust/extractor/src/qltest.rs:54
- Add a unit test for
set_sourcesthat includes sample paths both inside and outside atargetdirectory to verify the filtering logic works as intended.
fn set_sources(config: &mut Config) -> anyhow::Result<()> {
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM. I will see if this fixes CI on a couple of my PRs tomorrow morning.
| fn set_sources(config: &mut Config) -> anyhow::Result<()> { | ||
| let path_iterator = glob("**/*.rs").context("globbing test sources")?; | ||
| config.inputs = path_iterator | ||
| .filter(|f| f.is_err() || !f.as_ref().unwrap().starts_with("target")) |
There was a problem hiding this comment.
I guess your intention is to keep Err paths, right? So any errors are not silently ignored. If you just want to drop Err paths then it might be nicer to use f.is_ok_and() instead of the is_err check and unwrapping.
There was a problem hiding this comment.
yeah, I hesitated between the two, but in the end opted for not suppressing the errors for now
|
Seems to have worked, everything is looking better this morning. Thanks again! |
The target file created by
cargo checkwas causing problems in language tests.We might want to also ignore
targetby default in the production indexing, but I'll leave that for further discussion.