Rust: Follow-up work to make path resolution and type inference tests pass again

[hvitved]

#19506 follow-up.

[Copilot]

Pull Request Overview

This PR updates the Rust QL tests and library modules to filter out macro-generated AST nodes, enforce source-only elements, and reflect real standard-library paths in test expectations. Key changes include:

• Adding fromSource() and isFromMacroExpansion() filters in type inference and path resolution tests
• Updating expected outputs to point to the real core/result definitions in the Rust stdlib
• Implementing new predicates (fromSource, startsBefore, startsStrictlyBefore, etc.) and adapting path-resolution and type-inference logic in the QL libraries

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
rust/ql/test/library-tests/type-inference/type-inference.ql	Added source/macro filters to inferType and related predicates
rust/ql/test/library-tests/type-inference/type-inference.expected	Updated expected test outputs to real stdlib Result and Arguments paths
rust/ql/test/library-tests/path-resolution/path-resolution.ql	Applied source/macro filters to resolvePath queries
rust/ql/test/library-tests/path-resolution/path-resolution.expected	Updated expected module paths to real stdlib locations
rust/ql/test/TestUtils.qll	Expanded toBeTested to only include source AST nodes
rust/ql/lib/utils/test/PathResolutionInlineExpectationsTest.qll	Added source/macro filters to inline-expectations test helpers
rust/ql/lib/codeql/rust/internal/TypeInference.qll	Adjusted hard-coded debug line number
rust/ql/lib/codeql/rust/internal/PathResolution.qll	Replaced getModuleNode with getSourceFile, removed outdated isRoot
rust/ql/lib/codeql/rust/frameworks/stdlib/Stdlib.qll	Refactored OptionEnum/ResultEnum to use getASuccessor
rust/ql/lib/codeql/rust/elements/internal/MacroCallImpl.qll	Introduced isInMacroExpansion and getATokenTreeNode
rust/ql/lib/codeql/rust/elements/internal/LocationImpl.qll	Renamed/extended location predicates (startsBefore, etc.)
rust/ql/lib/codeql/rust/elements/internal/LocatableImpl.qll	Changed fromSource to delegate to File.fromSource()
rust/ql/lib/codeql/rust/elements/internal/AstNodeImpl.qll	Hooked isInMacroExpansion into new MacroCallImpl predicates
rust/ql/lib/codeql/files/FileSystem.qll	Strengthened File.fromSource() by requiring a relative path

Comments suppressed due to low confidence (1)

rust/ql/test/TestUtils.qll:17

• The CrateElement predicate no longer includes this instanceof Crate, which may prevent actual Crate elements from being recognized. Consider restoring this instanceof Crate in the predicate.

this instanceof NamedCrate

[Copilot]

[nitpick] Avoid hard-coding line numbers in production predicates. Consider computing this value dynamically or defining a named constant to explain its origin.

[Copilot]

[nitpick] To make the OR conditions clearer, wrap each branch in parentheses. For example: (f.getAPrecedingComment().getCommentText() = value and f.fromSource()) or (not any(f.getAPrecedingComment()).fromSource() and value = f.getName().getText()).

[aibaars]

Here the home directory is leaking into expected test output.

[hvitved]

I believe those should be fixed when you merge latest main into your branch, which contains

codeql/rust/ql/test/library-tests/type-inference/type-inference.ql

Line 8 in e6235a5

class TypeLoc extends TypeFinal {

.