Skip to content

Add CodeQL Quantum models and queries (Java, C++) to experimental #19469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolaswill merged 139 commits into from
May 12, 2025

Make FlowAwareElement private

5334e90
Select commit
Loading
Failed to load commit list.
Merged

Add CodeQL Quantum models and queries (Java, C++) to experimental #19469

Make FlowAwareElement private
5334e90
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed May 12, 2025 in 9s

7 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 7 configurations present on refs/heads/main were not found:

Actions workflow (rust-analysis.yml)

  • ❓  .github/workflows/rust-analysis.yml:analyze/language:rust

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 199 warnings
  • 32 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 2 in cpp/ql/lib/experimental/quantum/Language.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
OpenSSL.OpenSSL
Loading
.

Check warning on line 57 in cpp/ql/lib/experimental/quantum/Language.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 13 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in KnownOpenSSLAlgorithmToAlgorithmValueConsumerConfig should be PascalCase/camelCase.

Check warning on line 41 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in KnownOpenSSLAlgorithmToAlgorithmValueConsumerFlow should be PascalCase/camelCase.

Check warning on line 44 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in RSAPaddingAlgorithmToPaddingAlgorithmValueConsumerConfig should be PascalCase/camelCase.

Check warning on line 58 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in RSAPaddingAlgorithmToPaddingAlgorithmValueConsumerFlow should be PascalCase/camelCase.

Check warning on line 61 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in OpenSSLAlgorithmAdditionalFlowStep should be PascalCase/camelCase.

Check warning on line 112 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in NIDToPointerPassthroughCall should be PascalCase/camelCase.

Check warning on line 148 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/AlgToAVCFlow.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in PointerToNIDPassthroughCall should be PascalCase/camelCase.

Check warning on line 2 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
OpenSSLAlgorithmInstanceBase
Loading
.
Redundant import, the module is already imported inside
experimental.quantum.OpenSSL.AlgorithmValueConsumers.DirectAlgorithmValueConsumer
Loading
.

Check warning on line 4 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
experimental.quantum.OpenSSL.AlgorithmValueConsumers.DirectAlgorithmValueConsumer
Loading
.
Redundant import, the module is already imported inside
AlgToAVCFlow
Loading
.

Check warning on line 12 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in knownOpenSSLConstantToBlockModeFamilyType should be PascalCase/camelCase.

Check notice on line 18 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 22 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 24 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 26 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 28 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 30 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 32 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 34 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check notice on line 36 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Use of regexp to match a set of constant string Note

Use string comparison instead of regexp to compare against a constant set of string.

Check warning on line 41 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in KnownOpenSSLBlockModeConstantAlgorithmInstance should be PascalCase/camelCase.

Check warning on line 54 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
OpenSSLAlgorithmValueConsumer
Loading
.

Check warning on line 75 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/BlockAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in getAVC should be PascalCase/camelCase.

Check warning on line 2 in cpp/ql/lib/experimental/quantum/OpenSSL/AlgorithmInstances/CipherAlgorithmInstance.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
OpenSSLAlgorithmInstanceBase
Loading
.
Redundant import, the module is already imported inside
PaddingAlgorithmInstance
Loading
.
Redundant import, the module is already imported inside
BlockAlgorithmInstance
Loading
.