Skip to content

Shared: Use isSink/1 in PropagateFlowConfig #19404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 1 commit into from
Apr 29, 2025
Merged

Shared: Use isSink/1 in PropagateFlowConfig #19404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,10 +484,14 @@ module MakeModelGenerator<
}

predicate isSink(DataFlow::Node sink, FlowState state) {
// Sinks are provided by `isSink/1`
none()
}

predicate isSink(DataFlow::Node sink) {
sink instanceof ReturnNodeExt and
not isOwnInstanceAccessNode(sink) and
not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink))) and
(state instanceof TaintRead or state instanceof TaintStore)
not exists(captureQualifierFlow(getAsExprEnclosingCallable(sink)))
}

predicate isAdditionalFlowStep(
Expand Down
Loading