Skip to content

Dataflow: Make default field flow branch limit configurable per language #19361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jketema merged 1 commit into from
Apr 24, 2025
Merged

Dataflow: Make default field flow branch limit configurable per language #19361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions shared/dataflow/codeql/dataflow/DataFlow.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,9 @@ signature module InputSig<LocationSig Location> {
any()
}

/** Gets the default value for the `fieldFlowBranchLimit` */
default int defaultFieldFlowBranchLimit() { result = 2 }

/** Holds if `fieldFlowBranchLimit` should be ignored for flow going into/out of `c`. */
default predicate ignoreFieldFlowBranchLimit(DataFlowCallable c) { none() }
}
Expand Down Expand Up @@ -399,7 +402,7 @@ module Configs<LocationSig Location, InputSig<Location> Lang> {
* This can be overridden to a smaller value to improve performance (a
* value of 0 disables field flow), or a larger value to get more results.
*/
default int fieldFlowBranchLimit() { result = 2 }
default int fieldFlowBranchLimit() { result = Lang::defaultFieldFlowBranchLimit() }

/** Gets the access path limit. */
default int accessPathLimit() { result = Lang::accessPathLimit() }
Expand Down Expand Up @@ -548,7 +551,7 @@ module Configs<LocationSig Location, InputSig<Location> Lang> {
* This can be overridden to a smaller value to improve performance (a
* value of 0 disables field flow), or a larger value to get more results.
*/
default int fieldFlowBranchLimit() { result = 2 }
default int fieldFlowBranchLimit() { result = Lang::defaultFieldFlowBranchLimit() }

/** Gets the access path limit. */
default int accessPathLimit() { result = Lang::accessPathLimit() }
Expand Down
Loading