Skip to content

Shared: Match line information on Alert and Sink locations. #19354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 2 commits into from
Apr 24, 2025
Merged

Shared: Match line information on Alert and Sink locations. #19354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
617f472
Shared: Match line information on Alert and Sink locations.
michaelnebel Apr 23, 2025
2e0ce44
Javascript: Update test files.
michaelnebel Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions javascript/ql/test/query-tests/Security/CWE-078/CommandInjection/child_process-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var server = http.createServer(function(req, res) {
sh = 'cmd.exe', flag = '/c';
else
sh = '/bin/sh', flag = '-c';
cp.spawn(sh, [ flag, cmd ]); // $ Alert Sink
cp.spawn(sh, [ flag, cmd ]); // $ Alert

let args = [];
args[0] = "-c";
Expand All @@ -53,8 +53,8 @@ var server = http.createServer(function(req, res) {
args[1] = cmd; // $ Sink
cp.execFile(`/bin` + "/bash", args); // $ Alert

cp.spawn('cmd.exe', ['/C', 'foo'].concat(["bar", cmd])); // $ Alert Sink
cp.spawn('cmd.exe', ['/C', 'foo'].concat(cmd)); // $ Alert Sink
cp.spawn('cmd.exe', ['/C', 'foo'].concat(["bar", cmd])); // $ Alert
cp.spawn('cmd.exe', ['/C', 'foo'].concat(cmd)); // $ Alert

let myArgs = [];
myArgs.push(`-` + "c");
Expand Down
2 changes: 1 addition & 1 deletion javascript/ql/test/query-tests/Security/CWE-078/CommandInjection/exec-sh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function getShell() {

function execSh(command, options) {
var shell = getShell()
return cp.spawn(shell.cmd, [shell.arg, command], options) // $ Alert Sink
return cp.spawn(shell.cmd, [shell.arg, command], options) // $ Alert
}

http.createServer(function (req, res) {
Expand Down
2 changes: 1 addition & 1 deletion javascript/ql/test/query-tests/Security/CWE-078/CommandInjection/exec-sh2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function getShell() {
}

function execSh(command, options) {
return cp.spawn(getShell(), ["-c", command], options) // $ Alert Sink
return cp.spawn(getShell(), ["-c", command], options) // $ Alert
};

http.createServer(function (req, res) {
Expand Down
4 changes: 2 additions & 2 deletions ...ipt/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/isImported.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
const cp = require("child_process");

module.exports.thisMethodIsImported = function (name) { // $ Source
cp.exec("rm -rf " + name); // $ Alert Sink
}
cp.exec("rm -rf " + name); // $ Alert
}
Loading
Loading