Skip to content

Rust: Fix capturedCallRead #19185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 3 commits into from
Apr 2, 2025
Merged

Rust: Fix capturedCallRead #19185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01810cb
Rust: Update `PhiDefinition.toString`
hvitved Apr 1, 2025
9dea9f5
SSA: Make `phiWithoutTwoPriorRefs` consistency check more informative
hvitved Apr 1, 2025
dcaeeab
Rust: Fix `capturedCallRead`
hvitved Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/dataflow/Ssa.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ module Ssa {
not exists(this.getSplitString()) and
prefix = ""
|
result = prefix + "phi"
result = prefix + SsaImpl::PhiDefinition.super.toString()
)
}

Expand Down
2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/dataflow/internal/SsaImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ private predicate capturedCallRead(Expr call, BasicBlock bb, int i, Variable v)
hasCapturedRead(pragma[only_bind_into](v), pragma[only_bind_into](scope)) and
(
variableWriteInOuterScope(bb, any(int j | j < i), v, scope) or
variableWriteInOuterScope(bb.getAPredecessor+(), _, v, scope)
variableWriteInOuterScope(bb.getImmediateDominator+(), _, v, scope)
) and
call = bb.getNode(i).getAstNode()
)
Expand Down
Loading
Loading