Skip to content

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Mar 26, 2025

In this PR we update the generated .NET 9 Runtime models.
There are two commits updating the models

  • In the first commit the .NET 9 Runtime models are updated as is, without any changes to the model generator (as some manual models have been added and changes has been made to the data flow library, since the last .NET 9 model generation).
  • In the second commit, we use the changes implemented on C#: Correct printing of returns via out/ref parameters in model generation. #19114 which leads to some model changes
    • Some changes to summaries are trivial in the sense that ReturnValue is changed to Argument[...] (as expected).
    • Some summaries have disappeared (for ref parameters), which is also expected, in case they were just created due to a use of a ref parameter. An example of this, is the summary of System.Buffers.ReadOnlySequence<T>.TryGet.

@github-actions github-actions bot added the C# label Mar 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",47,12255,54,5
+    System,"``System.*``, ``System``",47,12111,54,5
-    Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.AspNetCore.Components``, ``Microsoft.AspNetCore.Http``, ``Microsoft.AspNetCore.Mvc``, ``Microsoft.AspNetCore.WebUtilities``, ``Microsoft.CSharp``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.DotNet.PlatformAbstractions``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.JSInterop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",60,2272,152,4
+    Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.AspNetCore.Components``, ``Microsoft.AspNetCore.Http``, ``Microsoft.AspNetCore.Mvc``, ``Microsoft.AspNetCore.WebUtilities``, ``Microsoft.CSharp``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.DotNet.PlatformAbstractions``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.JSInterop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",60,2252,152,4
-    Totals,,107,14534,400,9
+    Totals,,107,14370,400,9
  • Changes to framework-coverage-csharp.csv:
- Internal.TypeSystem,,,345,,,,,,,,,,,,,,,,,,,205,140
+ Internal.TypeSystem,,,342,,,,,,,,,,,,,,,,,,,205,137
- Microsoft.Diagnostics.Tools.Pgo,,,23,,,,,,,,,,,,,,,,,,,,23
+ Microsoft.Diagnostics.Tools.Pgo,,,21,,,,,,,,,,,,,,,,,,,,21
- Microsoft.Extensions.Configuration,,3,123,,,,,,,,,,,,,3,,,,,,40,83
+ Microsoft.Extensions.Configuration,,3,118,,,,,,,,,,,,,3,,,,,,41,77
- Microsoft.Extensions.Primitives,,,76,,,,,,,,,,,,,,,,,,,67,9
+ Microsoft.Extensions.Primitives,,,75,,,,,,,,,,,,,,,,,,,68,7
- Microsoft.VisualBasic,,,13,,,,,,,,,,,,,,,,,,,1,12
+ Microsoft.VisualBasic,,,6,,,,,,,,,,,,,,,,,,,1,5
- Mono.Linker,,,280,,,,,,,,,,,,,,,,,,,129,151
+ Mono.Linker,,,278,,,,,,,,,,,,,,,,,,,130,148
- System,54,47,12255,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5955,6300
+ System,54,47,12111,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5993,6118

@michaelnebel michaelnebel force-pushed the csharp/updatedotnet9models branch from b386dd8 to 155a2cd Compare March 26, 2025 14:27
@michaelnebel
Copy link
Contributor Author

DCA looks good!

@michaelnebel michaelnebel marked this pull request as ready for review March 27, 2025 13:20
Copilot AI review requested due to automatic review settings March 27, 2025 13:20
@michaelnebel michaelnebel requested a review from a team as a code owner March 27, 2025 13:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the generated .NET 9 Runtime models and adds a corresponding change note.

  • Updates the .NET 9 Runtime models without changes to the model generator
  • Applies changes from a previous commit to adjust summaries for out/ref parameters

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@michaelnebel michaelnebel force-pushed the csharp/updatedotnet9models branch from 155a2cd to de6e3ea Compare April 1, 2025 06:33
@michaelnebel michaelnebel merged commit 8bf2ceb into github:main Apr 1, 2025
21 checks passed
@michaelnebel michaelnebel deleted the csharp/updatedotnet9models branch April 1, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants