Rust: Small type inference tweaks #19038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
commented
Mar 17, 2025
| Declaration getTarget() { | ||
| result = | ||
| [ | ||
| CallExprImpl::getResolvedFunction(this).(AstNode), |
Contributor
Author
There was a problem hiding this comment.
Note, this line calls getResolvedFunction and casts to AstNode. The next line calls getResolvedFunction and calls to Struct. Seems like the later will always be included in the former.
hvitved
previously approved these changes
Mar 17, 2025
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM, just one question.
| println!("{:?}", x.a); | ||
| } | ||
|
|
||
| fn generic_field_access() { |
Contributor
There was a problem hiding this comment.
Do all the expressions in this test have correctly inferred types (I didn't bother to check the .expected file)?
Contributor
Author
There was a problem hiding this comment.
I believe so, yes :)
Contributor
Author
|
I've merged main. |
hvitved
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small changes I made when reading through the type inference implementation.