Skip to content

Rust/Swift: Add get(Immediate)Child predicate #18985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvitved merged 2 commits into from
Mar 13, 2025
Merged

Rust/Swift: Add get(Immediate)Child predicate #18985

hvitved merged 2 commits into from
Mar 13, 2025

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Mar 12, 2025

No description provided.

@github-actions github-actions bot added Rust Pull requests that update Rust code Swift labels Mar 12, 2025
@hvitved hvitved marked this pull request as ready for review March 12, 2025 13:09
Copilot AI review requested due to automatic review settings March 12, 2025 13:09
@hvitved hvitved requested a review from a team as a code owner March 12, 2025 13:09
Copilot AI reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@hvitved hvitved added the no-change-note-required This PR does not need a change note label Mar 12, 2025
@hvitved hvitved requested a review from redsun82 March 12, 2025 13:47
geoffw0
geoffw0 previously approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's an integration test failure.

@hvitved
Copy link
Contributor Author

hvitved commented Mar 13, 2025

LGTM. There's an integration test failure.

Yeah, I'm not sure why that is, I don't see how this PR could cause that. @redsun82 what do you think?

@redsun82
Copy link
Contributor

redsun82 commented Mar 13, 2025

@hvitved that failure is a timeout flake. The DB checks failures in the logs are red herrings: they are actually xfail (expected failures): we never got around to clean up integration tests of them. I should probably tweak the pytest framework to not be that verbose on expected failures.

redsun82
redsun82 previously approved these changes Mar 13, 2025
View reviewed changes
@hvitved hvitved dismissed stale reviews from redsun82 and geoffw0 via dd21dab March 13, 2025 10:13
@hvitved hvitved force-pushed the rust/immediate-child branch from f971a5d to dd21dab Compare March 13, 2025 10:13
@hvitved
Copy link
Contributor Author

hvitved commented Mar 13, 2025

Rebased to resolve merge conflict in rust/ql/.generated.list.

@hvitved hvitved merged commit 1636abb into github:main Mar 13, 2025
25 checks passed
@hvitved hvitved deleted the rust/immediate-child branch March 13, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

@redsun82 redsun82 redsun82 left review comments

Assignees

No one assigned

Labels

no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code Swift

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hvitved @redsun82 @geoffw0